[cfe-commits] r87048 - /cfe/trunk/include/clang/AST/Redeclarable.h
Chris Lattner
sabre at nondot.org
Thu Nov 12 16:57:01 PST 2009
Author: lattner
Date: Thu Nov 12 18:57:01 2009
New Revision: 87048
URL: http://llvm.org/viewvc/llvm-project?rev=87048&view=rev
Log:
add a fixme, inheriting from PointerIntPair is gross :)
Modified:
cfe/trunk/include/clang/AST/Redeclarable.h
Modified: cfe/trunk/include/clang/AST/Redeclarable.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Redeclarable.h?rev=87048&r1=87047&r2=87048&view=diff
==============================================================================
--- cfe/trunk/include/clang/AST/Redeclarable.h (original)
+++ cfe/trunk/include/clang/AST/Redeclarable.h Thu Nov 12 18:57:01 2009
@@ -23,6 +23,8 @@
class Redeclarable {
protected:
+ // FIXME: PointerIntPair is a value class that should not be inherited from.
+ // This should change to using containment.
struct DeclLink : public llvm::PointerIntPair<decl_type *, 1, bool> {
DeclLink(decl_type *D, bool isLatest)
: llvm::PointerIntPair<decl_type *, 1, bool>(D, isLatest) { }
More information about the cfe-commits
mailing list