[cfe-commits] r86868 - in /cfe/trunk/lib/Sema: Sema.h SemaTemplate.cpp

[Douglas Gregor]

Author: dgregor
Date: Wed Nov 11 13:41:09 2009
New Revision: 86868

URL: http://llvm.org/viewvc/llvm-project?rev=86868&view=rev
Log:
Move handling of template parameter packs out of the
template-type-parameter specific template argument checking code and
up to the template argument checking loop. In theory, this should make
variadic templates work better; in practice, they don't well enough
for us to care anyway (YET!), so this is mostly a re-organization to
simplify CheckTemplateArgument.


Modified:
    cfe/trunk/lib/Sema/Sema.h
    cfe/trunk/lib/Sema/SemaTemplate.cpp

Modified: cfe/trunk/lib/Sema/Sema.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.h?rev=86868&r1=86867&r2=86868&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/Sema.h (original)
+++ cfe/trunk/lib/Sema/Sema.h Wed Nov 11 13:41:09 2009
@@ -2587,12 +2587,8 @@
     
   bool CheckTemplateArgument(NamedDecl *Param,
                              const TemplateArgumentLoc &Arg,
-                             unsigned ArgIdx,
                              TemplateDecl *Template,
                              SourceLocation TemplateLoc,
-                             SourceLocation LAngleLoc,
-                             const TemplateArgumentLoc *TemplateArgs,
-                             unsigned NumTemplateArgs,
                              SourceLocation RAngleLoc,
                              TemplateArgumentListBuilder &Converted);
   

Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplate.cpp?rev=86868&r1=86867&r2=86868&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaTemplate.cpp (original)
+++ cfe/trunk/lib/Sema/SemaTemplate.cpp Wed Nov 11 13:41:09 2009
@@ -1610,34 +1610,16 @@
 /// template parameter.
 bool Sema::CheckTemplateArgument(NamedDecl *Param,
                                  const TemplateArgumentLoc &Arg,
-                                 unsigned ArgIdx,
                                  TemplateDecl *Template,
                                  SourceLocation TemplateLoc,
-                                 SourceLocation LAngleLoc,
-                                 const TemplateArgumentLoc *TemplateArgs,
-                                 unsigned NumTemplateArgs,
                                  SourceLocation RAngleLoc,
                                  TemplateArgumentListBuilder &Converted) {
-  if (TemplateTypeParmDecl *TTP = dyn_cast<TemplateTypeParmDecl>(Param)) {
-    // Check template type parameters.
-    if (TTP->isParameterPack()) {
-      // Check all the remaining arguments (if any).
-      Converted.BeginPack();
-      for (; ArgIdx < NumTemplateArgs; ++ArgIdx) {
-        if (CheckTemplateTypeArgument(TTP, TemplateArgs[ArgIdx], Converted))
-          return true;
-      }
-      
-      Converted.EndPack();
-      return false;
-    } 
-    
+  // Check template type parameters.
+  if (TemplateTypeParmDecl *TTP = dyn_cast<TemplateTypeParmDecl>(Param))
     return CheckTemplateTypeArgument(TTP, Arg, Converted);
-  }
   
-  if (NonTypeTemplateParmDecl *NTTP =dyn_cast<NonTypeTemplateParmDecl>(Param)) {
-    // Check non-type template parameters.
-    
+  // Check non-type template parameters.
+  if (NonTypeTemplateParmDecl *NTTP =dyn_cast<NonTypeTemplateParmDecl>(Param)) {    
     // Do substitution on the type of the non-type template parameter
     // with the template arguments we've seen thus far.
     QualType NTTPType = NTTP->getType();
@@ -1740,7 +1722,7 @@
     }
       
     case TemplateArgument::Pack:
-      assert(0 && "FIXME: Implement!");
+      llvm::llvm_unreachable("Caller must expand template argument packs");
       break;
     }
     
@@ -1802,7 +1784,7 @@
     break;
     
   case TemplateArgument::Pack:
-    assert(0 && "FIXME: Implement!");
+    llvm::llvm_unreachable("Caller must expand template argument packs");
     break;
   }
   
@@ -1859,6 +1841,21 @@
     if (ArgIdx > NumArgs && PartialTemplateArgs)
       break;
 
+    // If we have a template parameter pack, check every remaining template
+    // argument against that template parameter pack.
+    if ((*Param)->isTemplateParameterPack()) {
+      Converted.BeginPack();
+      for (; ArgIdx < NumArgs; ++ArgIdx) {
+        if (CheckTemplateArgument(*Param, TemplateArgs[ArgIdx], Template,
+                                  TemplateLoc, RAngleLoc, Converted)) {
+          Invalid = true;
+          break;
+        }
+      }
+      Converted.EndPack();
+      continue;
+    }
+    
     // Decode the template argument
     TemplateArgumentLoc Arg;
 
@@ -1926,8 +1923,7 @@
       Arg = TemplateArgs[ArgIdx];
     }
     
-    if (CheckTemplateArgument(*Param, Arg, ArgIdx, Template, TemplateLoc,
-                              LAngleLoc, TemplateArgs, NumTemplateArgs, 
+    if (CheckTemplateArgument(*Param, Arg, Template, TemplateLoc,
                               RAngleLoc, Converted))
       return true;
   }