[cfe-commits] r85875 - in /cfe/trunk: include/clang/Analysis/PathSensitive/BugType.h include/clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h lib/Analysis/GRExprEngineInternalChecks.cpp lib/Analysis/UndefinedArgChecker.cpp

[Zhongxing Xu]

Author: zhongxingxu
Date: Tue Nov  3 00:46:03 2009
New Revision: 85875

URL: http://llvm.org/viewvc/llvm-project?rev=85875&view=rev
Log:
Pull UndefinedArgChecker into its own files.

Added:
    cfe/trunk/include/clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h
    cfe/trunk/lib/Analysis/UndefinedArgChecker.cpp
Modified:
    cfe/trunk/include/clang/Analysis/PathSensitive/BugType.h
    cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp

Modified: cfe/trunk/include/clang/Analysis/PathSensitive/BugType.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/BugType.h?rev=85875&r1=85874&r2=85875&view=diff

==============================================================================
--- cfe/trunk/include/clang/Analysis/PathSensitive/BugType.h (original)
+++ cfe/trunk/include/clang/Analysis/PathSensitive/BugType.h Tue Nov  3 00:46:03 2009
@@ -81,5 +81,6 @@
 
   template <typename ITER> void Emit(BugReporter& BR, ITER I, ITER E);
 };
+
 } // end clang namespace
 #endif

Added: cfe/trunk/include/clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h?rev=85875&view=auto

==============================================================================
--- cfe/trunk/include/clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h (added)
+++ cfe/trunk/include/clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h Tue Nov  3 00:46:03 2009
@@ -0,0 +1,30 @@
+//===--- UndefinedArgChecker.h - Undefined arguments checker ----*- C++ -*--==//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This defines BadCallChecker, a builtin check in GRExprEngine that performs
+// checks for undefined arguments.
+//
+//===----------------------------------------------------------------------===//
+
+#include "clang/Analysis/PathSensitive/CheckerVisitor.h"
+
+namespace clang {
+
+class UndefinedArgChecker : public CheckerVisitor<UndefinedArgChecker> {
+  BugType *BT;
+
+public:
+  UndefinedArgChecker() : BT(0) {}
+
+  static void *getTag();
+
+  void PreVisitCallExpr(CheckerContext &C, const CallExpr *CE);
+};
+
+}

Modified: cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp?rev=85875&r1=85874&r2=85875&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp (original)
+++ cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp Tue Nov  3 00:46:03 2009
@@ -19,6 +19,7 @@
 #include "clang/Analysis/PathSensitive/Checkers/UndefDerefChecker.h"
 #include "clang/Analysis/PathSensitive/Checkers/DivZeroChecker.h"
 #include "clang/Analysis/PathSensitive/Checkers/BadCallChecker.h"
+#include "clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h"
 #include "clang/Analysis/PathDiagnostic.h"
 #include "clang/Basic/SourceManager.h"
 #include "llvm/Support/Compiler.h"
@@ -596,42 +597,6 @@
   }
 };
 
-// Undefined arguments checking.
-
-class VISIBILITY_HIDDEN CheckUndefinedArg
-  : public CheckerVisitor<CheckUndefinedArg> {
-
-  BadArg *BT;
-
-public:
-  CheckUndefinedArg() : BT(0) {}
-  ~CheckUndefinedArg() {}
-
-  static void *getTag() {
-    static int x = 0;
-    return &x;
-  }
-
-  void PreVisitCallExpr(CheckerContext &C, const CallExpr *CE);
-};
-
-void CheckUndefinedArg::PreVisitCallExpr(CheckerContext &C, const CallExpr *CE){
-  for (CallExpr::const_arg_iterator I = CE->arg_begin(), E = CE->arg_end();
-       I != E; ++I) {
-    if (C.getState()->getSVal(*I).isUndef()) {
-      if (ExplodedNode *ErrorNode = C.GenerateNode(CE, true)) {
-        if (!BT)
-          BT = new BadArg();
-        // Generate a report for this bug.
-        ArgReport *Report = new ArgReport(*BT, BT->getDescription().c_str(),
-                                          ErrorNode, *I);
-        Report->addRange((*I)->getSourceRange());
-        C.EmitReport(Report);
-      }
-    }
-  }
-}
-
 } // end clang namespace
 
 //===----------------------------------------------------------------------===//
@@ -661,7 +626,7 @@
   // automatically.  Note that the check itself is owned by the GRExprEngine
   // object.
   registerCheck<CheckAttrNonNull>(new CheckAttrNonNull());
-  registerCheck<CheckUndefinedArg>(new CheckUndefinedArg());
+  registerCheck<UndefinedArgChecker>(new UndefinedArgChecker());
   registerCheck<BadCallChecker>(new BadCallChecker());
   registerCheck<DivZeroChecker>(new DivZeroChecker());
   registerCheck<UndefDerefChecker>(new UndefDerefChecker());

Added: cfe/trunk/lib/Analysis/UndefinedArgChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/UndefinedArgChecker.cpp?rev=85875&view=auto

==============================================================================
--- cfe/trunk/lib/Analysis/UndefinedArgChecker.cpp (added)
+++ cfe/trunk/lib/Analysis/UndefinedArgChecker.cpp Tue Nov  3 00:46:03 2009
@@ -0,0 +1,43 @@
+//===--- UndefinedArgChecker.h - Undefined arguments checker ----*- C++ -*--==//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This defines BadCallChecker, a builtin check in GRExprEngine that performs
+// checks for undefined arguments.
+//
+//===----------------------------------------------------------------------===//
+
+#include "clang/Analysis/PathSensitive/Checkers/UndefinedArgChecker.h"
+#include "clang/Analysis/PathSensitive/BugReporter.h"
+
+using namespace clang;
+
+void *UndefinedArgChecker::getTag() {
+  static int x = 0;
+  return &x;
+}
+
+void UndefinedArgChecker::PreVisitCallExpr(CheckerContext &C, 
+                                           const CallExpr *CE){
+  for (CallExpr::const_arg_iterator I = CE->arg_begin(), E = CE->arg_end();
+       I != E; ++I) {
+    if (C.getState()->getSVal(*I).isUndef()) {
+      if (ExplodedNode *N = C.GenerateNode(CE, true)) {
+        if (!BT)
+          BT = new BugType("Pass-by-value argument in function call is "
+                           "undefined", "Logic error");
+        // Generate a report for this bug.
+        EnhancedBugReport *R = new EnhancedBugReport(*BT, BT->getName().c_str(),
+                                                     N);
+        R->addRange((*I)->getSourceRange());
+        R->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, *I);
+        C.EmitReport(R);
+      }
+    }
+  }
+}