[cfe-commits] Patch for PR5273

[Sebastian Redl]

John McCall wrote:
> The correct strategy is to start with the minimal possible case 
> — here, isa<CXXThisExpr>(S). If there are cases that doesn't cover that 
> you're certain you want to warn about, then add those in specifically — 
> for example, casts of this (or casts of casts of this, etc.) — and just 
> keep whitelisting expressions until you're happy with the warnings 
> you've got.
>
> I would write this function as:
>
> static bool IsCXXThisExpr(const Expr* E) {
> while (const CastExpr *CE = dyn_cast<CastExpr>(E))
> E = CE->getSubExpr();
> return isa<CXXThisExpr>(E);
> }
>   
E = E->IgnoreParenCasts();
?

Sebastian