[cfe-commits] r84949 - /cfe/trunk/lib/Sema/TreeTransform.h

[John McCall]

Benjamin Kramer wrote:
> Author: d0k
> Date: Fri Oct 23 05:48:09 2009
> New Revision: 84949
>
> URL: http://llvm.org/viewvc/llvm-project?rev=84949&view=rev
> Log:
> Silence GCC 4.3 warning.
>
> TreeTransform.h:2333: warning: suggest parentheses around && within ||
>
> Modified:
>     cfe/trunk/lib/Sema/TreeTransform.h
>
> Modified: cfe/trunk/lib/Sema/TreeTransform.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/TreeTransform.h?rev=84949&r1=84948&r2=84949&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/Sema/TreeTransform.h (original)
> +++ cfe/trunk/lib/Sema/TreeTransform.h Fri Oct 23 05:48:09 2009
> @@ -2331,8 +2331,7 @@
>  
>    QualType Result = TL.getType();
>    if (getDerived().AlwaysRebuild() ||
> -      ElementType != T->getElementType() &&
> -      Size.get() != T->getSizeExpr()) {
> +      (ElementType != T->getElementType() && Size.get() != T->getSizeExpr())) {
>      Result = getDerived().RebuildDependentSizedExtVectorType(ElementType,
>                                                           move(Size),
>                                                           T->getAttributeLoc());
>   

This is a good warning, actually;  this is a refactor-o, we should be 
rebuilding if either of the components changes under substitution.  
Presumably this doesn't trigger a bug because we're not testing for 
template substitution into dependently-sized ext vector types.

I'll fix it.

John.