[cfe-commits] r84419 - /cfe/trunk/tools/CIndex/CIndex.cpp

[Daniel Dunbar]

Hi Benjamin,

On Sun, Oct 18, 2009 at 9:11 AM, Benjamin Kramer
<benny.kra at googlemail.com> wrote:
> Author: d0k
> Date: Sun Oct 18 11:11:04 2009
> New Revision: 84419
>
> URL: http://llvm.org/viewvc/llvm-project?rev=84419&view=rev
> Log:
> CIndex: compute ClangPath lazily.

Thanks! One comment though,

>  class CIndexer : public Indexer {
> -  std::string ClangPath;
> +  static llvm::sys::Path ClangPath;

This probably shouldn't be static, in case of concurrency. It's not
that expensive to compute, so I think we should just have a copy per
CIndexer instead of bothering to add locks for it.

 - Daniel