[cfe-commits] r84198 - in /cfe/trunk: include/clang-c/Index.h tools/CIndex/CIndex.cpp tools/CIndex/CIndex.exports

[Daniel Dunbar]

Ping? This is breaking the MSVC builds. I'm may add some temporary
hack to work around this, but this should be fixed correctly.

 - Daniel

On Fri, Oct 16, 2009 at 9:50 AM, Chris Lattner <clattner at apple.com> wrote:
> On Oct 15, 2009, at 1:04 PM, Steve Naroff wrote:
>
>> Author: snaroff
>> Date: Thu Oct 15 15:04:39 2009
>> New Revision: 84198
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=84198&view=rev
>> Log:
>> Implement <rdar://problem/7303432> [Clang/Index] In-memory-style AST
>> generation API (initial API implementation).
>>
>> Added clang_createTranslationUnitFromSourceFile().
>> Changed clang_createIndex() to lookup the location of clang (using
>> dladdr).
>
> hi Steve,
>
> Obviously I shouldn't be reviewing patches backwards :)
>
>> +++ cfe/trunk/tools/CIndex/CIndex.cpp Thu Oct 15 15:04:39 2009
>> @@ -23,6 +23,9 @@
>> #include "clang/Basic/SourceManager.h"
>> #include "clang/Frontend/ASTUnit.h"
>> #include <cstdio>
>> +#include <dlfcn.h>
>> +#include "llvm/System/Path.h"
>
> This is using a bunch of non-portable functionality that we have
> wrappers for in llvm/System. Please use Path::GetMainExecutable
> instead of calling dladdr and  sys::Program::Execute instead of fork/
> exec/wait.  Thanks!
>
> -Chris
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>