[cfe-commits] r83199 - in /cfe/trunk/lib: Driver/Tools.cpp Frontend/InitPreprocessor.cpp

[Daniel Dunbar]

2009/10/1 Fariborz Jahanian <fjahanian at apple.com>:
> Your patch looked good  and I checked it in (with one minor
> refactoring). But, I am not a driver person and
> I am not familiar with the boundary set between what the driver
> processes and hands down to clang-cc and  what not.

I agree with Rafael that the non-fragile check should probably be in the driver

The general policy I *try* to follow is that all "policy decisions"
should be made in the driver, when possible. Basically, we want
clang-cc to behave very predictably based on its command line
arguments. It isn't a particularly strict line though, and will be
become fuzzier as we move towards integrating clang-cc and the driver
in a single binary.

 - Daniel

> - Thanks, Fariborz
>
> On Oct 1, 2009, at 10:56 AM, Rafael Espíndola wrote:
>
>>> Keeping with the idea of doing feature checks in clang instead of
>>> clang-cc, maybe the correct fix is to move this test to clang too?
>>
>> If it is, could you please test the attached patch? :-)
>>
>> Sorry about the regression.
>>
>> Cheers,
>> Rafael
>> <darwin.patch>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>