[cfe-commits] r83965 - in /cfe/trunk: lib/CodeGen/CGVtable.cpp test/CodeGenCXX/virt.cpp

Mike Stump mrs at apple.com
Tue Oct 13 14:52:04 PDT 2009


On Oct 13, 2009, at 2:42 PM, Douglas Gregor wrote:
> On Oct 13, 2009, at 3:55 AM, Mike Stump wrote:
>
>> Author: mrs
>> Date: Tue Oct 13 05:55:21 2009
>> New Revision: 83965
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=83965&view=rev
>> Log:
>> Refine handling for return value conversions with respect to virtual
>> offsets for covariant thunks.
>>
>> Modified:
>>   cfe/trunk/lib/CodeGen/CGVtable.cpp
>>   cfe/trunk/test/CodeGenCXX/virt.cpp
>
> This seems to be breaking on 32-bit x86:
>
> 	http://smooshlab.apple.com:8010/builders/clang-i386-darwin9/builds/6433

Yeah, I noticed and had already checked in a fix:

Changed by: mrs
Changed at: Tue 13 Oct 2009 14:34:44
Revision: 84031
Changed files:

	• lib/CodeGen/CGVtable.cpp
Comments:
Ensure we sign extend.

I'll watch the next build to ensure it is fixed.  Thanks.



More information about the cfe-commits mailing list