[cfe-commits] r83907 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/Sema.h lib/Sema/SemaExpr.cpp lib/Sema/SemaStmt.cpp test/SemaCXX/warn-assignment-condition.cpp

[John McCall]

Chris Lattner wrote:
> On Oct 12, 2009, at 2:59 PM, John McCall wrote:
>> URL: http://llvm.org/viewvc/llvm-project?rev=83907&view=rev
>> Log:
>> Implement -Wparentheses:  warn about using assignments in contexts 
>> that require
>> conditions.  Add a fixit to insert the parentheses.  Also fix a very 
>> minor
>> possible memory leak in 'for' conditions.
>>
>> Fixes PR 4876 and rdar://problem/7289172
>
> Awesome, thanks John.  Random question: should this warning default to 
> on?  I know that GCC doesn't default it to on, but perhaps clang should?

Hmm, probably.  I'll do that.

John.