[cfe-commits] r83981 - /cfe/trunk/lib/CodeGen/CGVtable.cpp

[Anders Carlsson]

On Oct 13, 2009, at 10:23 AM, Mike Stump wrote:

> Author: mrs
> Date: Tue Oct 13 12:23:44 2009
> New Revision: 83981
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=83981&view=rev
> Log:
> Remove FIXME.  We construct VBIndex very early, before any calls to OverrideMethod.
> 
> Modified:
>    cfe/trunk/lib/CodeGen/CGVtable.cpp
> 
> Modified: cfe/trunk/lib/CodeGen/CGVtable.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGVtable.cpp?rev=83981&r1=83980&r2=83981&view=diff
> 
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGVtable.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGVtable.cpp Tue Oct 13 12:23:44 2009
> @@ -121,7 +121,6 @@
>     i = VBIndex.find(B);
>     if (i != VBIndex.end())
>       return i->second;
> -    // FIXME: temporal botch, is this data here, by the time we need it?
> 
>     assert(false && "FIXME: Locate the containing virtual base first");
>     return 0;

Cool, can we assert that i != VBIndex.end() in that case instead of asserting false later?

Anders