[cfe-commits] r83552 - /cfe/trunk/lib/AST/DeclCXX.cpp

[Douglas Gregor]

On Oct 12, 2009, at 11:38 AM, Fariborz Jahanian wrote:

>
> On Oct 9, 2009, at 3:53 PM, Douglas Gregor wrote:
>
>>
>> On Oct 8, 2009, at 9:33 AM, Fariborz Jahanian wrote:
>>
>>> Author: fjahanian
>>> Date: Thu Oct  8 11:33:37 2009
>>> New Revision: 83552
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=83552&view=rev
>>> Log:
>>> Refactoring to further simplify collection of visible conversion
>>> functions.
>>>
>>> Modified:
>>>  cfe/trunk/lib/AST/DeclCXX.cpp
>>>
>>> Modified: cfe/trunk/lib/AST/DeclCXX.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DeclCXX.cpp?rev=83552&r1=83551&r2=83552&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- cfe/trunk/lib/AST/DeclCXX.cpp (original)
>>> +++ cfe/trunk/lib/AST/DeclCXX.cpp Thu Oct  8 11:33:37 2009
>>> @@ -357,21 +357,21 @@
>>>   }
>>> }
>>>
>>> +  if (getNumBases() == 0 && getNumVBases() == 0)
>>> +    return;
>>> +
>>> +  llvm::SmallPtrSet<QualType, 8> ConversionFunctions;
>>
>> If the SmallPtrSet stored CanQualTypes, we would know (statically)  
>> that all types in ConversionFunctions were canonical.
> Done in http://llvm.org/viewvc/llvm-project?view=rev&revision=83869.
> But, I am not sure if this completely accommodates your comment.


It does, thanks!

	- Doug