[cfe-commits] r83345 - /cfe/trunk/include/clang/AST/Attr.h

Mike Stump mrs at apple.com
Mon Oct 5 16:40:59 PDT 2009


Author: mrs
Date: Mon Oct  5 18:40:59 2009
New Revision: 83345

URL: http://llvm.org/viewvc/llvm-project?rev=83345&view=rev
Log:
This is slightly contentious, but, if llvm has gone to addressable
units, we should as well.  The problem is the non-predictability of
the dimension of the values.  I'd love for the dimension to be part of
the static type system...  but in C++ it is kinda annoying to do.

Modified:
    cfe/trunk/include/clang/AST/Attr.h

Modified: cfe/trunk/include/clang/AST/Attr.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Attr.h?rev=83345&r1=83344&r2=83345&view=diff

==============================================================================
--- cfe/trunk/include/clang/AST/Attr.h (original)
+++ cfe/trunk/include/clang/AST/Attr.h Mon Oct  5 18:40:59 2009
@@ -185,6 +185,7 @@
 public:
   AlignedAttr(unsigned alignment) : Attr(Aligned), Alignment(alignment) {}
 
+  // FIXME: Should use addressable units, not bits, to match llvm
   /// getAlignment - The specified alignment in bits.
   unsigned getAlignment() const { return Alignment; }
 





More information about the cfe-commits mailing list