[cfe-commits] r83199 - in /cfe/trunk/lib: Driver/Tools.cpp Frontend/InitPreprocessor.cpp

[Chris Lattner]

On Oct 1, 2009, at 6:33 AM, Rafael Espindola wrote:
Author: rafael
> Date: Thu Oct  1 08:33:33 2009
> New Revision: 83199
>
> URL: http://llvm.org/viewvc/llvm-project?rev=83199&view=rev
> Log:
> Move the "needs exception support" logic to clang. This also fixes
> -fno-exceptions in C++ code. We used to always define __EXCEPTIONS in
> C++.

Hi Rafael,

One random question:

> +++ cfe/trunk/lib/Frontend/InitPreprocessor.cpp Thu Oct  1 08:33:33  
> 2009
> @@ -274,7 +274,6 @@
>     if (LangOpts.ObjCNonFragileABI) {
>       DefineBuiltinMacro(Buf, "__OBJC2__=1");
>       DefineBuiltinMacro(Buf, "OBJC_ZEROCOST_EXCEPTIONS=1");
> -      DefineBuiltinMacro(Buf, "__EXCEPTIONS=1");
>     }

Did you verify that x86-64 objective-c is still getting this #define?

-Chris

>
>     if (LangOpts.getGCMode() != LangOptions::NonGC)
> @@ -299,9 +298,11 @@
>     DefineBuiltinMacro(Buf, "__BLOCKS__=1");
>   }
>
> +  if (LangOpts.Exceptions)
> +    DefineBuiltinMacro(Buf, "__EXCEPTIONS=1");
> +
>   if (LangOpts.CPlusPlus) {
>     DefineBuiltinMacro(Buf, "__DEPRECATED=1");
> -    DefineBuiltinMacro(Buf, "__EXCEPTIONS=1");
>     DefineBuiltinMacro(Buf, "__GNUG__=4");
>     DefineBuiltinMacro(Buf, "__GXX_WEAK__=1");
>     if (LangOpts.GNUMode)
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits