[cfe-commits] [patch] function parameters can not be qualified with an address space error

[Douglas Gregor]

On Sep 30, 2009, at 1:01 PM, Tanya Lattner wrote:

>
> On Sep 30, 2009, at 12:05 PM, John McCall wrote:
>
>> Tanya Lattner wrote:
>>> Hello.
>>>
>>> I'd like to get the attached patch reviewed. Parameters to a  
>>> function can not be qualified by an address space qualifier  
>>> according to the embedded C extension. I just added a new error  
>>> for this situation and modified the address_space.c test case to  
>>> check for this as well. I have run all the clang tests.
>>
>> This generally looks good, but ActOnParamDeclarator is a more  
>> appropriate place for the check;  CheckParmsForFunctionDef is only  
>> called for function definitions, and this error should also trigger  
>> on on function declarations.
>>
>
> Excellent point. I've updated my patch and the test case to account  
> for that situation. Please let me know if you have any other  
> feedback or if its ok to commit.

Looks good! Please go ahead and commit.

	- Doug