[cfe-commits] [patch] function parameters can not be qualified with an address space error
John McCall
rjmccall at apple.com
Wed Sep 30 12:05:52 PDT 2009
Tanya Lattner wrote:
> Hello.
>
> I'd like to get the attached patch reviewed. Parameters to a function
> can not be qualified by an address space qualifier according to the
> embedded C extension. I just added a new error for this situation and
> modified the address_space.c test case to check for this as well. I
> have run all the clang tests.
This generally looks good, but ActOnParamDeclarator is a more
appropriate place for the check; CheckParmsForFunctionDef is only
called for function definitions, and this error should also trigger on
on function declarations.
John.
More information about the cfe-commits
mailing list