[cfe-commits] r82672 - in /cfe/trunk: lib/Analysis/GRExprEngineInternalChecks.cpp test/Analysis/uninit-vals-ps-region.c test/Analysis/uninit-vals-ps.c

[Ted Kremenek]

Author: kremenek
Date: Wed Sep 23 19:44:26 2009
New Revision: 82672

URL: http://llvm.org/viewvc/llvm-project?rev=82672&view=rev
Log:
Shorten the static analyzer diagnostic for 'use of garbage value'.

Modified:
    cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp
    cfe/trunk/test/Analysis/uninit-vals-ps-region.c
    cfe/trunk/test/Analysis/uninit-vals-ps.c

Modified: cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp?rev=82672&r1=82671&r2=82672&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp (original)
+++ cfe/trunk/lib/Analysis/GRExprEngineInternalChecks.cpp Wed Sep 23 19:44:26 2009
@@ -235,9 +235,9 @@
                 
         if (Ex) {
           OS << "The " << (isLeft ? "left" : "right")
-             << " operand of the '"
+             << " operand of '"
              << BinaryOperator::getOpcodeStr(B->getOpcode())
-             << "' expression is a garbage value";
+             << "' is a garbage value";
         }          
         else {
           // Neither operand was undefined, but the result is undefined.

Modified: cfe/trunk/test/Analysis/uninit-vals-ps-region.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/uninit-vals-ps-region.c?rev=82672&r1=82671&r2=82672&view=diff

==============================================================================
--- cfe/trunk/test/Analysis/uninit-vals-ps-region.c (original)
+++ cfe/trunk/test/Analysis/uninit-vals-ps-region.c Wed Sep 23 19:44:26 2009
@@ -25,7 +25,7 @@
   struct TestUninit v2 = test_uninit_aux();
   int z;
   v1.y = z;
-  test_unit_aux2(v2.x + v1.y);  // expected-warning{{The right operand of the '+' expression is a garbage value}}
+  test_unit_aux2(v2.x + v1.y);  // expected-warning{{The right operand of '+' is a garbage value}}
 }
 void test_uninit_neg() {
   struct TestUninit v1 = { 0, 0 };

Modified: cfe/trunk/test/Analysis/uninit-vals-ps.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/uninit-vals-ps.c?rev=82672&r1=82671&r2=82672&view=diff

==============================================================================
--- cfe/trunk/test/Analysis/uninit-vals-ps.c (original)
+++ cfe/trunk/test/Analysis/uninit-vals-ps.c Wed Sep 23 19:44:26 2009
@@ -22,7 +22,7 @@
   
   int x;
   
-  if (x+1)  // expected-warning{{The left operand of the '+' expression is a garbage value}}
+  if (x+1)  // expected-warning{{The left operand of '+' is a garbage value}}
     return 1;
     
   return 2;  
@@ -31,13 +31,13 @@
 int f2_b() {
   int x;
   
-  return ((1+x)+2+((x))) + 1 ? 1 : 2; // expected-warning{{The right operand of the '+' expression is a garbage value}}
+  return ((1+x)+2+((x))) + 1 ? 1 : 2; // expected-warning{{The right operand of '+' is a garbage value}}
 }
 
 int f3(void) {
   int i;
   int *p = &i;
-  if (*p > 0) // expected-warning{{The left operand of the '>' expression is a garbage value}}
+  if (*p > 0) // expected-warning{{The left operand of '>' is a garbage value}}
     return 0;
   else
     return 1;