[cfe-commits] r82459 - in /cfe/trunk: include/clang/Sema/CodeCompleteConsumer.h lib/Lex/Lexer.cpp lib/Sema/CodeCompleteConsumer.cpp lib/Sema/ParseAST.cpp lib/Sema/Sema.h lib/Sema/SemaCodeComplete.cpp

[Chris Lattner]

On Sep 21, 2009, at 9:56 AM, Douglas Gregor wrote:

> Author: dgregor
> Date: Mon Sep 21 11:56:56 2009
> New Revision: 82459
>
> URL: http://llvm.org/viewvc/llvm-project?rev=82459&view=rev
> Log:
> Refactor and simplify the CodeCompleteConsumer, so that all of the
> real work is performed within Sema. Addresses Chris's comments, but
> still retains the heavyweight list-of-multimaps data structure.

CodeCompleteConsumer looks great now, thanks Doug!

One minor thought: in CodeCompleteConsumer::Result, would it make  
sense to add accessor methods like getKeyword() / getDeclaration()  
that asserted the ResultKind was correct before poking it?

-Chris