[cfe-commits] Fix for crash with specialization?

Eli Friedman eli.friedman at gmail.com
Tue Sep 15 17:12:23 PDT 2009


On Tue, Sep 15, 2009 at 5:05 PM, Douglas Gregor <dgregor at apple.com> wrote:
>
> On Sep 15, 2009, at 5:01 PM, Eli Friedman wrote:
>
>> Attached prevents the following from crashing:
>> template<typename _CharT> struct A {int x();};
>> template<> int A<char>::x() { return 1; }
>>
>> Does the patch look close to correct, or is the issue more fundamental?
>
>
> We should only call RequireCompleteDeclContext if !DC->isDependentContext();
> otherwise, the patch looks good.
>
>        - Doug

Okay; where do you suggest I put the test?

-Eli




More information about the cfe-commits mailing list