[cfe-commits] r79288 - /cfe/trunk/lib/CodeGen/TargetABIInfo.cpp

David Chisnall csdavec at swansea.ac.uk
Thu Aug 20 05:23:40 PDT 2009


On 20 Aug 2009, at 07:15, Chris Lattner wrote:

> I admit that the original check for darwin was completely hideous  
> here, but this is making it a lot worse.  Can this be factored out  
> into targetInfo somehow?  At the very least, can this use  
> llvm::Triple to do this decoding?


Agreed - very ugly.  The attached patch makes it much less so.  Since  
we were already passing the Context, I've moved all of the  
architecture-specific tweaking inside the constructor and modified it  
to use llvm::Triple.

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.diff
Type: application/octet-stream
Size: 2346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090820/a9d56be9/attachment.obj>


More information about the cfe-commits mailing list