[cfe-commits] r79464 - in /cfe/trunk/lib/CodeGen: CGCXX.cpp CodeGenFunction.h

[Fariborz Jahanian]

On Aug 19, 2009, at 2:06 PM, Fariborz Jahanian wrote:

> I knew the general use. However, there is no break/continue in this  
> manufactured for-loop.
> Thus the comment. I don't think we need it, unless there is some  
> implied assumption requiring them.

My apologies. My response was not relevant. I read too fast.

- Fariborz

>
> - Thanks, Fariborz
>
> On Aug 19, 2009, at 2:02 PM, Anders Carlsson wrote:
>
>>
>> On Aug 19, 2009, at 1:55 PM, Fariborz Jahanian wrote:
>>>
>>> +  // Store the blocks to use for break and continue.
>>> +  // FIXME. Is this needed?
>>> +  BreakContinueStack.push_back(BreakContinue(AfterFor,  
>>> ContinueBlock));
>>
>> It's not needed. BreakContinueStack is used so we know where to  
>> jump when generating break and continue statements.
>>>
>>> +  // FIXME. Do we need this?
>>> +  BreakContinueStack.pop_back();
>>
>> Same here.
>>
>> Anders
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090819/3a6042e9/attachment.html>