[cfe-commits] [PATCH] Add _M_IX86 for Windows

[Anton Korobeynikov]

Hello, Everyone

> clang does not define _MSC_VER; it never has, and never will unless we
> introduce a vcpp emulation mode, which I don't find particularly
> likely.
Sorry, I misread MSVCR => _MSC_VER

> Some quick web research shows _M_IX86 does not necessarily imply MSVC.
>  Apparently Borland defines it, and the MinGW windows.h defines it if
> the compiler doesn't.  I don't see any issue with defining it.
I'd prefer to be as close to gcc as possible. It does not have this
built-in define, so clang should not have as well. The define coming
from special header like windows.h is fine.

> I'm not sure what the distinction between mingw and a "generic"
> windows target is in this context.  And we currently default to
> -fms-extensions on Windows, but it can be explicitly disabled.
Right, this is another area of possible fixes :)

-- 
With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.