[cfe-commits] r79288 - /cfe/trunk/lib/CodeGen/TargetABIInfo.cpp

Jonathan Gray jsg at goblin.cx
Tue Aug 18 02:28:09 PDT 2009


On Tue, Aug 18, 2009 at 11:26:29AM +0200, Jonathan Gray wrote:
> On Mon, Aug 17, 2009 at 11:08:21PM -0000, David Chisnall wrote:
> >    const char *TargetPrefix = getContext().Target.getTargetPrefix();
> >    if (strcmp(TargetPrefix, "x86") == 0) {
> >      bool IsDarwin = strstr(getContext().Target.getTargetTriple(), "darwin");
> > +    bool isPPCStructReturnABI = IsDarwin ||
> 
> This should be PCC as in Portable C Compiler, PPC confuses things.
> Additionally the logic seems to be the inverse of what is expected.
> Darwin does not set this for example.

apparently already fixed, nevermind.



More information about the cfe-commits mailing list