[cfe-commits] [PATCH] Blackfin target

[Eli Friedman]

On Mon, Aug 17, 2009 at 12:05 PM, Jakob Stoklund Olesen<stoklund at 2pi.dk> wrote:
> Hi,
>
> LLVM has a Blackfin back-end now. The attached patch adds Blackfin support
> to clang.
>
> Please review.

+    virtual const char *getClobbers() const {
+      return "";
+    }

You might want to double-check this... usually inline asm at least
clobbers the flag register, and IIRC Blackfin has one.

+    virtual const char *getVAListDeclaration() const {
+      // FIXME: implement
+      return "typedef char* __builtin_va_list;";
+    }
+  };

What's the FIXME about?

Otherwise, looks good.

-Eli