[cfe-commits] r78927 - /cfe/trunk/lib/CodeGen/CGCXX.cpp

[Mike Stump]

Author: mrs
Date: Thu Aug 13 13:39:54 2009
New Revision: 78927

URL: http://llvm.org/viewvc/llvm-project?rev=78927&view=rev
Log:
Minor cleanups.

Modified:
    cfe/trunk/lib/CodeGen/CGCXX.cpp

Modified: cfe/trunk/lib/CodeGen/CGCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCXX.cpp?rev=78927&r1=78926&r2=78927&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGCXX.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGCXX.cpp Thu Aug 13 13:39:54 2009
@@ -627,6 +627,7 @@
   typedef CXXRecordDecl::method_iterator meth_iter;
   llvm::Constant *m;
 
+  // FIXME: audit order
   for (meth_iter mi = RD->method_begin(),
          me = RD->method_end(); mi != me; ++mi) {
     if (mi->isVirtual()) {
@@ -758,13 +759,11 @@
       continue;
     const CXXRecordDecl *Base = 
       cast<CXXRecordDecl>(i->getType()->getAs<RecordType>()->getDecl());
-    if (PrimaryBase != Base) {
+    if (Base != PrimaryBase)
       GenerateVtableForBase(Base, RD, rtti, methods, false, false,
                             IndirectPrimary);
-    }
   }
 
-  // FIXME: finish layout for virtual bases
   // FIXME: Though complete, this is the wrong order
   for (CXXRecordDecl::base_class_const_iterator i = RD->vbases_begin(),
          e = RD->vbases_end(); i != e; ++i) {