[cfe-commits] r78846 - /cfe/trunk/lib/AST/RecordLayoutBuilder.cpp

[Mike Stump]

Author: mrs
Date: Wed Aug 12 17:06:55 2009
New Revision: 78846

URL: http://llvm.org/viewvc/llvm-project?rev=78846&view=rev
Log:
Refactor a bit and remove some FIXME audit markers, now that the code
has been audited for correctness.

Modified:
    cfe/trunk/lib/AST/RecordLayoutBuilder.cpp

Modified: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/RecordLayoutBuilder.cpp?rev=78846&r1=78845&r2=78846&view=diff

==============================================================================
--- cfe/trunk/lib/AST/RecordLayoutBuilder.cpp (original)
+++ cfe/trunk/lib/AST/RecordLayoutBuilder.cpp Wed Aug 12 17:06:55 2009
@@ -27,8 +27,7 @@
 
 /// LayoutVtable - Lay out the vtable and set PrimaryBase.
 void ASTRecordLayoutBuilder::LayoutVtable(const CXXRecordDecl *RD) {
-  // FIXME: audit indirect virtual bases
-  if (!RD->isPolymorphic() && !RD->getNumVBases()) {
+  if (!RD->isDynamicClass()) {
     // There is no primary base in this case.
     setPrimaryBase(0, false);
     return;
@@ -141,7 +140,6 @@
 
   // If we have no virtual bases at this point, bail out as the searching below
   // is expensive.
-  // FIXME: audit indirect virtual bases
   if (RD->getNumVBases() == 0) {
     return;
   }