[cfe-commits] r78542 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/Sema/attr-malloc.c

[Chris Lattner]

On Aug 11, 2009, at 1:18 PM, Ryan Flynn wrote:

> On Tue, Aug 11, 2009 at 4:12 PM, Chris Lattner<clattner at apple.com>  
> wrote:
>> On Aug 9, 2009, at 3:36 PM, Ryan Flynn wrote:
>>>
>>> Author: pizza
>>> Date: Sun Aug  9 17:36:29 2009
>>> New Revision: 78542
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=78542&view=rev
>>> Log:
>>> warn, as gcc does, if __attribute__((malloc)) applied to function
>>> returning non-pointer type
>>
>> Thanks Ryan.  If "d" is not a functiondecl, does it make sense to  
>> reject
>> (with a warning) the attribute?
>>
> I think it does, gcc does, and the block above the patch in
> SemaDeclAttr.cpp does just that.

Okay, so should it use "cast<FunctionDecl>" instead of dyn_cast?

-Chris