[cfe-commits] r78158 - in /cfe/trunk: lib/CodeGen/CodeGenModule.cpp test/CodeGen/global-init.c

[Chris Lattner]

Author: lattner
Date: Tue Aug  4 23:56:58 2009
New Revision: 78158

URL: http://llvm.org/viewvc/llvm-project?rev=78158&view=rev
Log:
rdar://7119244 - globals with an explicit section specified don't get
common linkage.

Modified:
    cfe/trunk/lib/CodeGen/CodeGenModule.cpp
    cfe/trunk/test/CodeGen/global-init.c

Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=78158&r1=78157&r2=78158&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Tue Aug  4 23:56:58 2009
@@ -883,7 +883,8 @@
   else if (D->hasAttr<WeakAttr>())
     GV->setLinkage(llvm::GlobalVariable::WeakAnyLinkage);
   else if (!CompileOpts.NoCommon &&
-           (!D->hasExternalStorage() && !D->getInit()))
+           !D->hasExternalStorage() && !D->getInit() &&
+           !D->getAttr<SectionAttr>())
     GV->setLinkage(llvm::GlobalVariable::CommonLinkage);
   else
     GV->setLinkage(llvm::GlobalVariable::ExternalLinkage);

Modified: cfe/trunk/test/CodeGen/global-init.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/global-init.c?rev=78158&r1=78157&r2=78158&view=diff

==============================================================================
--- cfe/trunk/test/CodeGen/global-init.c (original)
+++ cfe/trunk/test/CodeGen/global-init.c Tue Aug  4 23:56:58 2009
@@ -1,7 +1,14 @@
-// RUN: clang-cc -emit-llvm -o - %s | not grep "common"
+// RUN: clang-cc -emit-llvm -o - %s | FileCheck %s
 
 // This checks that the global won't be marked as common. 
 // (It shouldn't because it's being initialized).
 
 int a;
 int a = 242;
+// CHECK: @a = global i32 242
+
+// This shouldn't be emitted as common because it has an explicit section.
+// rdar://7119244
+int b __attribute__((section("foo")));
+
+// CHECK: @b = global i32 0, section "foo"