[cfe-commits] [PATCH] Refactor/fix some issues with templates and member initializers

Douglas Gregor dgregor at apple.com
Mon Jul 27 13:41:19 PDT 2009


On Jul 25, 2009, at 6:13 PM, Eli Friedman wrote:

> Patch attached.  Fixes all the testcases in PR4621.
>
> This change refactors ActOnMemInitializer so the relevant code can be
> called from template instantiation (although I haven't added the
> appropriate code).  It adds appropriate checks for arguments with
> dependent types.  It also fixes some broken logic for member
> initializers which would reject initializing a member with a dependent
> type.

Looks good to me, thanks!

There don't seem to be any test cases; does this fix PR 4627 and/or PR  
4621?

> I've attached both a regular diff and a diff -w because the latter is
> a bit easier to read; I ended up reindenting a lot of the code.


The -w is definitely easier to read. Thanks!

	- Doug



More information about the cfe-commits mailing list