[cfe-commits] r77061 - /cfe/trunk/utils/test/TestRunner.py

Daniel Dunbar daniel at zuster.org
Sat Jul 25 03:14:32 PDT 2009


Author: ddunbar
Date: Sat Jul 25 05:14:19 2009
New Revision: 77061

URL: http://llvm.org/viewvc/llvm-project?rev=77061&view=rev
Log:
MultiTestRunner: Explicitly define child environment, the only variable we need
to import is the PATH.

Modified:
    cfe/trunk/utils/test/TestRunner.py

Modified: cfe/trunk/utils/test/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/test/TestRunner.py?rev=77061&r1=77060&r2=77061&view=diff

==============================================================================
--- cfe/trunk/utils/test/TestRunner.py (original)
+++ cfe/trunk/utils/test/TestRunner.py Sat Jul 25 05:14:19 2009
@@ -23,10 +23,8 @@
 import subprocess
 import sys
 
-# Increase determinism for things that use the terminal width.
-#
-# FIXME: Find a better place for this hack.
-os.environ['COLUMNS'] = '0'
+# Increase determinism by explicitly choosing the environment.
+kChildEnv = { 'PATH' : os.environ.get('PATH','') }
 
 kSystemName = platform.system()
 
@@ -163,7 +161,8 @@
                              cwd=os.path.dirname(FILENAME),
                              stdin=subprocess.PIPE,
                              stdout=subprocess.PIPE,
-                             stderr=subprocess.PIPE)
+                             stderr=subprocess.PIPE,
+                             env=kChildEnv)
         out,err = p.communicate()
         outputFile.write(out)
         outputFile.write(err)





More information about the cfe-commits mailing list