[cfe-commits] r76851 - in /cfe/trunk: include/clang/Analysis/PathSensitive/GRExprEngine.h lib/Analysis/GRExprEngine.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Wed Jul 22 23:41:06 2009
New Revision: 76851

URL: http://llvm.org/viewvc/llvm-project?rev=76851&view=rev
Log:
Revert r76831, there are many Analyzer test failures on multiple platforms.

--- Reverse-merging r76831 into '.':
U    include/clang/Analysis/PathSensitive/GRExprEngine.h
U    lib/Analysis/GRExprEngine.cpp

Modified:
    cfe/trunk/include/clang/Analysis/PathSensitive/GRExprEngine.h
    cfe/trunk/lib/Analysis/GRExprEngine.cpp

Modified: cfe/trunk/include/clang/Analysis/PathSensitive/GRExprEngine.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/PathSensitive/GRExprEngine.h?rev=76851&r1=76850&r2=76851&view=diff

==============================================================================
--- cfe/trunk/include/clang/Analysis/PathSensitive/GRExprEngine.h (original)
+++ cfe/trunk/include/clang/Analysis/PathSensitive/GRExprEngine.h Wed Jul 22 23:41:06 2009
@@ -585,9 +585,6 @@
                                      ObjCMessageExpr::arg_iterator E,
                                      NodeTy* Pred, NodeSet& Dst);
   
-  void VisitObjCMessageExprDispatchCheckers(ObjCMessageExpr* ME, NodeTy* Pred,
-                                            NodeSet& Dst);
-  
   void VisitObjCMessageExprDispatchHelper(ObjCMessageExpr* ME, NodeTy* Pred,
                                           NodeSet& Dst);
   

Modified: cfe/trunk/lib/Analysis/GRExprEngine.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRExprEngine.cpp?rev=76851&r1=76850&r2=76851&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/GRExprEngine.cpp (original)
+++ cfe/trunk/lib/Analysis/GRExprEngine.cpp Wed Jul 22 23:41:06 2009
@@ -1855,12 +1855,12 @@
       Visit(Receiver, Pred, Tmp);
       
       for (NodeSet::iterator NI = Tmp.begin(), NE = Tmp.end(); NI != NE; ++NI)
-        VisitObjCMessageExprDispatchCheckers(ME, *NI, Dst);
+        VisitObjCMessageExprDispatchHelper(ME, *NI, Dst);
       
       return;
     }
     
-    VisitObjCMessageExprDispatchCheckers(ME, Pred, Dst);
+    VisitObjCMessageExprDispatchHelper(ME, Pred, Dst);
     return;
   }
   
@@ -1873,19 +1873,6 @@
     VisitObjCMessageExprArgHelper(ME, AI, AE, *NI, Dst);
 }
 
-void GRExprEngine::VisitObjCMessageExprDispatchCheckers(ObjCMessageExpr* ME,
-                                                        NodeTy* Pred,
-                                                        NodeSet& Dst) {
-  NodeSet Src;
-  Src.Add(Pred);
-  NodeSet DstTmp;
-  // Perform the previsit of the ObjCMessageExpr, storing the results in DstTmp.
-  CheckerVisit(ME, Src, DstTmp, true);
-  
-  for (NodeSet::iterator NI = DstTmp.begin(), NE = DstTmp.end(); NI != NE; ++NI)
-    VisitObjCMessageExprDispatchHelper(ME, *NI, Dst);
-}
-
 void GRExprEngine::VisitObjCMessageExprDispatchHelper(ObjCMessageExpr* ME,
                                                       NodeTy* Pred,
                                                       NodeSet& Dst) {
@@ -2056,7 +2043,7 @@
       return;
     }    
   }
-
+  
   // Check if we raise an exception.  For now treat these as sinks.  Eventually
   // we will want to handle exceptions properly.