[cfe-commits] r75649 - in /cfe/trunk: include/clang/Parse/Action.h lib/AST/DeclCXX.cpp lib/Parse/ParseCXXInlineMethods.cpp lib/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp

[Fariborz Jahanian]

On Jul 21, 2009, at 10:15 AM, Douglas Gregor wrote:

>
> On Jul 21, 2009, at 10:05 AM, Fariborz Jahanian wrote:
>
>>
>> On Jul 21, 2009, at 9:53 AM, Douglas Gregor wrote:
>>
>>>
>>> On Jul 14, 2009, at 11:24 AM, Fariborz Jahanian wrote:
>>>> =
>>>>
>>>
>>> This is quadratic in the number of initializers, which is rather  
>>> unfortunate. Can we do better than O(N^2)?
>>
>> Yes, but in practice explosion is controlled by number of unique  
>> virtual bases. Do you think it matters? Then
>> I will look at using faster search methods.
>
> Well, there's similar O(N^2) code for direct, non-virtual base  
> classes and for fields. It's pretty rare for there to be a large  
> number of base classes (virtual or non-virtual direct), but it is  
> relatively common to have quite a few fields. I think it's worth  
> giving some thought to whether we can make this code more  
> efficient... but if we can't think of something, just documenting it  
> with a FIXME: O(N^2) is fine.

OK. will look into this later on.
- fariborz

>