[cfe-commits] r75684 - in /cfe/trunk: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CodeGenModule.cpp test/CodeGenObjC/debug-info-linkagename.m test/CodeGenObjC/debug-info.m
Devang Patel
dpatel at apple.com
Tue Jul 14 14:31:23 PDT 2009
Author: dpatel
Date: Tue Jul 14 16:31:22 2009
New Revision: 75684
URL: http://llvm.org/viewvc/llvm-project?rev=75684&view=rev
Log:
Revert 75648 for now. It is causing test failures.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/CodeGen/CGDebugInfo.h
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
cfe/trunk/test/CodeGenObjC/debug-info-linkagename.m
cfe/trunk/test/CodeGenObjC/debug-info.m
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=75684&r1=75683&r2=75684&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Tue Jul 14 16:31:22 2009
@@ -19,7 +19,6 @@
#include "clang/AST/Expr.h"
#include "clang/Basic/SourceManager.h"
#include "clang/Basic/FileManager.h"
-#include "clang/Basic/TargetInfo.h"
#include "clang/Frontend/CompileOptions.h"
#include "llvm/Constants.h"
#include "llvm/DerivedTypes.h"
@@ -34,22 +33,12 @@
using namespace clang;
using namespace clang::CodeGen;
-CGDebugInfo::CGDebugInfo(CodeGenModule *m, TargetInfo *t)
+CGDebugInfo::CGDebugInfo(CodeGenModule *m)
: M(m), isMainCompileUnitCreated(false), DebugFactory(M->getModule()),
BlockLiteralGenericSet(false) {
- LLVMMangler = new llvm::Mangler(m->getModule(), t->getUserLabelPrefix(), ".");
- // add chars used in ObjC method names so method names aren't mangled
- LLVMMangler->markCharAcceptable('[');
- LLVMMangler->markCharAcceptable(']');
- LLVMMangler->markCharAcceptable('(');
- LLVMMangler->markCharAcceptable(')');
- LLVMMangler->markCharAcceptable('-');
- LLVMMangler->markCharAcceptable('+');
- LLVMMangler->markCharAcceptable(' ');
}
CGDebugInfo::~CGDebugInfo() {
- delete LLVMMangler;
assert(RegionStack.empty() && "Region stack mismatch, stack not empty!");
}
@@ -831,6 +820,8 @@
void CGDebugInfo::EmitFunctionStart(const char *Name, QualType ReturnType,
llvm::Function *Fn,
CGBuilderTy &Builder) {
+ const char *LinkageName = Name;
+
// Skip the asm prefix if it exists.
//
// FIXME: This should probably be the unmangled name?
@@ -843,9 +834,7 @@
unsigned LineNo = SM.getPresumedLoc(CurLoc).getLine();
llvm::DISubprogram SP =
- DebugFactory.CreateSubprogram(Unit, Name, Name,
- LLVMMangler->getMangledName(Fn),
- Unit, LineNo,
+ DebugFactory.CreateSubprogram(Unit, Name, Name, LinkageName, Unit, LineNo,
getOrCreateType(ReturnType, Unit),
Fn->hasInternalLinkage(), true/*definition*/);
@@ -980,9 +969,7 @@
ArrayType::Normal, 0);
}
- DebugFactory.CreateGlobalVariable(Unit, Name, Name,
- LLVMMangler->getMangledName(Var),
- Unit, LineNo,
+ DebugFactory.CreateGlobalVariable(Unit, Name, Name, "", Unit, LineNo,
getOrCreateType(T, Unit),
Var->hasInternalLinkage(),
true/*definition*/, Var);
@@ -1012,9 +999,7 @@
ArrayType::Normal, 0);
}
- DebugFactory.CreateGlobalVariable(Unit, Name, Name,
- LLVMMangler->getMangledName(Var),
- Unit, LineNo,
+ DebugFactory.CreateGlobalVariable(Unit, Name, Name, "", Unit, LineNo,
getOrCreateType(T, Unit),
Var->hasInternalLinkage(),
true/*definition*/, Var);
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.h?rev=75684&r1=75683&r2=75684&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGDebugInfo.h (original)
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.h Tue Jul 14 16:31:22 2009
@@ -16,7 +16,6 @@
#include "clang/AST/Type.h"
#include "clang/Basic/SourceLocation.h"
-#include "llvm/Support/Mangler.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/Analysis/DebugInfo.h"
#include <map>
@@ -26,7 +25,6 @@
namespace clang {
class VarDecl;
class ObjCInterfaceDecl;
- class TargetInfo;
namespace CodeGen {
class CodeGenModule;
@@ -36,7 +34,6 @@
/// the backend.
class CGDebugInfo {
CodeGenModule *M;
- llvm::Mangler *LLVMMangler;
bool isMainCompileUnitCreated;
llvm::DIFactory DebugFactory;
@@ -71,7 +68,7 @@
llvm::DIType CreateType(const ArrayType *Ty, llvm::DICompileUnit U);
public:
- CGDebugInfo(CodeGenModule *m, TargetInfo *t);
+ CGDebugInfo(CodeGenModule *m);
~CGDebugInfo();
/// setLocation - Update the current source location. If \arg loc is
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.cpp?rev=75684&r1=75683&r2=75684&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CodeGenModule.cpp (original)
+++ cfe/trunk/lib/CodeGen/CodeGenModule.cpp Tue Jul 14 16:31:22 2009
@@ -52,9 +52,7 @@
Runtime = CreateMacObjCRuntime(*this);
// If debug info generation is enabled, create the CGDebugInfo object.
- DebugInfo = 0;
- if (CompileOpts.DebugInfo)
- DebugInfo = new CGDebugInfo(this, &Context.Target);
+ DebugInfo = CompileOpts.DebugInfo ? new CGDebugInfo(this) : 0;
}
CodeGenModule::~CodeGenModule() {
Modified: cfe/trunk/test/CodeGenObjC/debug-info-linkagename.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/debug-info-linkagename.m?rev=75684&r1=75683&r2=75684&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenObjC/debug-info-linkagename.m (original)
+++ cfe/trunk/test/CodeGenObjC/debug-info-linkagename.m Tue Jul 14 16:31:22 2009
@@ -1,5 +1,7 @@
// RUN: clang-cc -g -S -o %t %s
// RUN: not grep 001 %t
+// XFAIL
+
@interface F
-(int) bar;
Modified: cfe/trunk/test/CodeGenObjC/debug-info.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/debug-info.m?rev=75684&r1=75683&r2=75684&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenObjC/debug-info.m (original)
+++ cfe/trunk/test/CodeGenObjC/debug-info.m Tue Jul 14 16:31:22 2009
@@ -1,7 +1,7 @@
// RUN: clang-cc -triple i386-apple-darwin9 -g -emit-llvm -o %t %s &&
// RUN: grep '@.str3 = internal constant \[8 x i8\] c"-\[A m0\]\\00"' %t &&
-// RUN: grep '@.str4 = internal constant \[2 x i8\] c"A\\00"' %t &&
-// RUN: grep '@llvm.dbg.subprogram = .* @.str3, .* @.str3, .* @.str3,' %t &&
+// RUN: grep '@.str4 = internal constant \[9 x i8\] c"\\01-\[A m0\]\\00"' %t &&
+// RUN: grep '@llvm.dbg.subprogram = .* @.str3, .* @.str3, .* @.str4,' %t &&
// RUN: grep '@llvm.dbg.composite.* = .* i32 15, i64 0, i64 8, .* i32 16' %t &&
// RUN: true
More information about the cfe-commits
mailing list