[cfe-commits] r75505 - /cfe/trunk/lib/Sema/SemaExpr.cpp

[Chris Lattner]

On Jul 13, 2009, at 2:20 PM, Steve Naroff wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=75505&view=rev
> Log:
> Sema::CheckAdditionOperands(): Use Type::getPointeeType() and remove  
> PTy and OPT variables.

Thanks Steve,

> +      } else {
> +        // Check if we require a complete type.
> +        if (((PExp->getType()->isPointerType() &&
> +              !PExp->getType()->getAsPointerType()- 
> >isDependentType()) ||

I don't think you need "->getAsPointerType()" here, isdependenttype  
doesn't need a pointer type.

-Chris

> +              PExp->getType()->isObjCObjectPointerType()) &&
> +             RequireCompleteType(Loc, PointeeTy,
> +                                  
> diag::err_typecheck_arithmetic_incomplete_type,
> +                                 PExp->getSourceRange(),  
> SourceRange(),
> +                                 PExp->getType()))
> +          return QualType();
> +      }
>       // Diagnose bad cases where we step over interface counts.
>       if (PointeeTy->isObjCInterfaceType() &&  
> LangOpts.ObjCNonFragileABI) {
>         Diag(Loc, diag::err_arithmetic_nonfragile_interface)
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits