[cfe-commits] r74935 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/SemaObjC/property-expression-error.m

[Fariborz Jahanian]

Author: fjahanian
Date: Tue Jul  7 13:50:52 2009
New Revision: 74935

URL: http://llvm.org/viewvc/llvm-project?rev=74935&view=rev
Log:
Diagnose, and not crash, when taking address of property expression.


Added:
    cfe/trunk/test/SemaObjC/property-expression-error.m
Modified:
    cfe/trunk/lib/Sema/SemaExpr.cpp

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=74935&r1=74934&r2=74935&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Tue Jul  7 13:50:52 2009
@@ -4678,6 +4678,11 @@
     Diag(OpLoc, diag::err_typecheck_address_of)
       << "vector element" << op->getSourceRange();
     return QualType();
+  } else if (isa<ObjCPropertyRefExpr>(op)) {
+    // cannot take address of a property expression.
+    Diag(OpLoc, diag::err_typecheck_address_of)
+      << "property expression" << op->getSourceRange();
+    return QualType();
   } else if (dcl) { // C99 6.5.3.2p1
     // We have an lvalue with a decl. Make sure the decl is not declared
     // with the register storage-class specifier.

Added: cfe/trunk/test/SemaObjC/property-expression-error.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/property-expression-error.m?rev=74935&view=auto

==============================================================================
--- cfe/trunk/test/SemaObjC/property-expression-error.m (added)
+++ cfe/trunk/test/SemaObjC/property-expression-error.m Tue Jul  7 13:50:52 2009
@@ -0,0 +1,18 @@
+// RUN: clang-cc  -fsyntax-only -verify %s
+
+ at interface AddressMyProperties 
+{
+  unsigned index;
+}
+ at property unsigned index;
+ at end
+
+ at implementation AddressMyProperties
+ at synthesize index;
+ at end
+
+int main() {
+	AddressMyProperties *object;
+	&object.index; // expected-error {{address of property expression requested}}
+	return 0;
+}