[cfe-commits] Fwd: Patch for bug #4175

[Chris Lattner]

On Jun 15, 2009, at 3:03 PM, David Majnemer wrote:

> Sorry! I forgot to send this to the list.

Hi David, sorry for the delay, but your patch looks great!  Applied  
here:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090629/018645.html

-Chris

>
>
> ---------- Forwarded message ----------
> From: David Majnemer <david.majnemer at gmail.com>
> Date: Mon, Jun 15, 2009 at 3:02 PM
> Subject: Re: [cfe-commits] Patch for bug #4175
> To: Chris Lattner <clattner at apple.com>
>
>
> I updated the patch to address the issues. If you need additional test
> cases, I can add some.
>
> --
> David
>
> On Fri, Jun 12, 2009 at 1:53 PM, Chris Lattner <clattner at apple.com>  
> wrote:
>>
>> On Jun 12, 2009, at 10:09 AM, David Majnemer wrote:
>>
>> Please understand that this is my first attempt at trying to submit  
>> something, I apologize if I have done anything wrong.
>> Anyway, this patch has some changes to the warnings that we could  
>> emit. I personally felt that alternatives would be harder to read.
>> If the patch is not up to snuff, I would be more than happy to try  
>> to fix it.
>>
>> Hi David,
>> This looks nice to me, but it looks like you have some 4-space  
>> indentation in the patch:
>> +    if (rType->isFunctionPointerType() || lType- 
>> >isFunctionPointerType()) {
>> +        if (isRelational) {
>> +          Diag(Loc,  
>> diag::ext_typecheck_ordered_comparison_of_function_pointers)
>> +            << lType << rType << lex->getSourceRange() << rex- 
>> >getSourceRange();
>> +        }
>> +    }
>> +    if (((!LHSIsNull || isRelational) && LCanPointeeTy- 
>> >isVoidType()) !=
>> +        ((!RHSIsNull || isRelational) && RCanPointeeTy- 
>> >isVoidType())) {
>> +        Diag(Loc,  
>> diag::ext_typecheck_comparison_of_distinct_pointers)
>> +          << lType << rType << lex->getSourceRange() << rex- 
>> >getSourceRange();
>> +    }
>>      // Simple check: if the pointee types are identical, we're done.
>> Please change this to indent by 2, include a testcase and I'll  
>> apply it for you.
>> Thanks!
>> -Chris
> <bug_4175.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits