[cfe-commits] r74008 - in /cfe/trunk: lib/CodeGen/CGObjCGNU.cpp lib/CodeGen/CGObjCMac.cpp lib/CodeGen/CGObjCRuntime.h lib/CodeGen/CodeGenModule.cpp test/CodeGenObjC/deadcode_strip_used_var.m

Fariborz Jahanian fjahanian at apple.com
Wed Jun 24 08:12:17 PDT 2009


On Jun 24, 2009, at 8:07 AM, Daniel Dunbar wrote:

> Hi Fariborz,
>
> I think this is more complicated than it need be, can't the runtime
> just use CodeGenModule::AddUsedGlobal to add the things it wants to
> mark used onto the global metadata used list?

This was my first attempt. Two problems. 1) Above API was meant for  
'used' attribute on decls.  and
asserts any any other kind of declarations. 2) I did not want to  
misuse LLVMUsed for anything
other than what it was originally intended for. This is in case, other  
clients want to preserve
this distinction. Change looks like a lot, but it is pretty simple.

- Fariborz




More information about the cfe-commits mailing list