[cfe-commits] Small patch

Douglas Gregor dgregor at apple.com
Wed Jun 17 12:50:17 PDT 2009


On Jun 17, 2009, at 12:59 AM, Anis Ahmad wrote:

> On Tue, Jun 16, 2009 at 11:35 PM, Eli Friedman  
> <eli.friedman at gmail.com> wrote:
>>
>> That's reasonable in this case, since it's the most straightforward
>> way to recover.
>>
>> The test should probably go into test/Parser rather than test/ 
>> CXX/...;
>> it's not testing functionality in the standard.  Also, in case you
>> haven't figured it out, the way to make -verify work in this case is
>> to put something like the following at the end of the line with the
>> error:
>>
>> namespace B __attribute__ (( static )) = A; //
>> expected-error{{unexpected attribute specifiers in namespace alias}}
>>
>> The usual code style around here is two-space indentation, no braces
>> around single-line if statements, and no "!= 0" in an if condition
>> testing a pointer; otherwise, I think the patch looks fine.
>
> Ok, thanks.  I've updated the patch by moving the test to test/Parser,
> and changing the code to match the common code style.

Great, thanks! I've committed it here:

	http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090615/018258.html

	- Doug



More information about the cfe-commits mailing list