[cfe-commits] r72591 - in /cfe/trunk: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp lib/CodeGen/CGCXX.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.cpp

[Anders Carlsson]

29 maj 2009 kl. 23.01 skrev Douglas Gregor:

>
> On May 29, 2009, at 2:03 PM, Anders Carlsson wrote:
>> +const CXXDestructorDecl *
>> +CXXRecordDecl::getDestructor(ASTContext &Context) {
>> +  QualType ClassType = Context.getTypeDeclType(this);
>
> You should grab the canonical type here (ClassType =  
> Context.getCanonicalType(ClassType)), lest our search for a  
> destructor fail.
>

Hmm, can you ever end up with a non-canonical type when calling  
getTypeDeclType? If not, I'll add an assert instead.

Thanks for the reviews!
Anders