[cfe-commits] r72353 - /cfe/trunk/lib/CodeGen/CGExprAgg.cpp

Mike Stump mrs at apple.com
Sat May 23 16:52:31 PDT 2009


Author: mrs
Date: Sat May 23 18:52:31 2009
New Revision: 72353

URL: http://llvm.org/viewvc/llvm-project?rev=72353&view=rev
Log:
Propagate volatile for implicit property refernces.

Modified:
    cfe/trunk/lib/CodeGen/CGExprAgg.cpp

Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprAgg.cpp?rev=72353&r1=72352&r2=72353&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGExprAgg.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGExprAgg.cpp Sat May 23 18:52:31 2009
@@ -235,13 +235,12 @@
                             RValue::getAggregate(AggLoc, VolatileDest));
   } 
   else if (LHS.isKVCRef()) {
-    // FIXME: Volatility?
     llvm::Value *AggLoc = DestPtr;
     if (!AggLoc)
       AggLoc = CGF.CreateTempAlloca(CGF.ConvertType(E->getRHS()->getType()));
-    CGF.EmitAggExpr(E->getRHS(), AggLoc, false);
+    CGF.EmitAggExpr(E->getRHS(), AggLoc, VolatileDest);
     CGF.EmitObjCPropertySet(LHS.getKVCRefExpr(), 
-                            RValue::getAggregate(AggLoc));
+                            RValue::getAggregate(AggLoc, VolatileDest));
   } else {
     // Codegen the RHS so that it stores directly into the LHS.
     CGF.EmitAggExpr(E->getRHS(), LHS.getAddress(), LHS.isVolatileQualified());





More information about the cfe-commits mailing list