[cfe-commits] [PATCH] Make ASTConsumers take file handles instead of file names

Daniel Dunbar daniel at zuster.org
Mon May 18 14:45:03 PDT 2009


On Mon, May 18, 2009 at 2:40 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Mon, May 18, 2009 at 10:38 AM, Daniel Dunbar <daniel at zuster.org> wrote:
>> Here is a related question: should ComputeOutputFile even exist? It
>> doesn't seem unreasonable to me to require that an output name be
>> given when one is required (and perhaps have a separate option
>> --output-stdout to output to standard out).
>
> This would mean giving up on being able to pass multiple files at a
> time to clang-cc.  I don't know if anyone actually does this, though.

True.

> As for requiring an explicit output name, there isn't any point in
> terms of simplifying the code; we can just default the output file
> name to "-", and let raw_fd_ostream take care of it.

Mostly I just hate having code in multiple places that does thing like
deriving output file names (i.e. replacing the suffix).

 - Daniel




More information about the cfe-commits mailing list