[cfe-commits] [PATCH] Make ASTConsumers take file handles instead of file names

Daniel Dunbar daniel at zuster.org
Mon May 18 10:38:18 PDT 2009


Hi Eli,

Looks good to me, thanks!

Here is a related question: should ComputeOutputFile even exist? It
doesn't seem unreasonable to me to require that an output name be
given when one is required (and perhaps have a separate option
--output-stdout to output to standard out).

 - Daniel

On Mon, May 18, 2009 at 2:52 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Sun, May 17, 2009 at 7:46 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> Patch attached.  There's one issue that I haven't worked out how to
>> fix: this causes a failure in
>> clang/test/CodeGen/2008-07-17-no-emit-on-error.c.
>
> Attached is a new version which fixes the test failure.  It's kind of
> ugly, though; I'm not sure this is the best approach.
>
> -Eli
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>




More information about the cfe-commits mailing list