[cfe-commits] [patch] Fixed for function specifiers

[Anders Johnsen]

Hi Eli,


> The isExplicitOkay changes look generally okay, except that I'm not
> sure about changing the text of the diagnostic: it's stating something
> that isn't actually true in C++0x.


Yeah, fixed.

I don't think the change to the signature of
> DiagnoseFunctionSpecifiers is a good idea: I never actually got around
> to implementing it, but it makes it impossible to fix the FIXME at the
> top of the function.  It may seem like code duplication, but I think
> I'd prefer to use separate diagnostics for the
> ParsedFreeStandingDeclSpec case.


Changed back, and tried to fix the FIXME.  (should be removed if solution is
approved)

Thanks!

- Anders
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090513/e27b913e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: function-specifiers.patch
Type: text/x-diff
Size: 6630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090513/e27b913e/attachment.patch>