[cfe-commits] r70387 - /cfe/trunk/lib/Analysis/CFRefCount.cpp

Ted Kremenek kremenek at apple.com
Wed Apr 29 10:09:14 PDT 2009


Author: kremenek
Date: Wed Apr 29 12:09:14 2009
New Revision: 70387

URL: http://llvm.org/viewvc/llvm-project?rev=70387&view=rev
Log:
Rename getMethodSummary() -> getInstanceMethodSummary().

Modified:
    cfe/trunk/lib/Analysis/CFRefCount.cpp

Modified: cfe/trunk/lib/Analysis/CFRefCount.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/CFRefCount.cpp?rev=70387&r1=70386&r2=70387&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/CFRefCount.cpp (original)
+++ cfe/trunk/lib/Analysis/CFRefCount.cpp Wed Apr 29 12:09:14 2009
@@ -730,12 +730,12 @@
   
   RetainSummary* getSummary(FunctionDecl* FD);  
   
-  RetainSummary* getMethodSummary(ObjCMessageExpr* ME, ObjCInterfaceDecl* ID) {
-    return getMethodSummary(ME->getSelector(), ME->getClassName(),
+  RetainSummary* getInstanceMethodSummary(ObjCMessageExpr* ME, ObjCInterfaceDecl* ID) {
+    return getInstanceMethodSummary(ME->getSelector(), ME->getClassName(),
                             ID, ME->getMethodDecl(), ME->getType());    
   }
   
-  RetainSummary* getMethodSummary(Selector S, IdentifierInfo *ClsName,
+  RetainSummary* getInstanceMethodSummary(Selector S, IdentifierInfo *ClsName,
                                   ObjCInterfaceDecl* ID,
                                   ObjCMethodDecl *MD, QualType RetTy);
 
@@ -1208,9 +1208,11 @@
 }
 
 RetainSummary*
-RetainSummaryManager::getMethodSummary(Selector S, IdentifierInfo *ClsName,
-                                       ObjCInterfaceDecl* ID,
-                                       ObjCMethodDecl *MD, QualType RetTy) {
+RetainSummaryManager::getInstanceMethodSummary(Selector S,
+                                               IdentifierInfo *ClsName,
+                                               ObjCInterfaceDecl* ID,
+                                               ObjCMethodDecl *MD,
+                                               QualType RetTy) {
 
   // Look up a summary in our summary cache.
   ObjCMethodSummariesTy::iterator I = ObjCMethodSummaries.find(ID, ClsName, S);
@@ -2145,7 +2147,9 @@
       }
     }
     
-    Summ = Summaries.getMethodSummary(ME, ID);
+    // FIXME: The receiver could be a reference to a class, meaning that
+    //  we should use the class method.
+    Summ = Summaries.getInstanceMethodSummary(ME, ID);
 
     // Special-case: are we sending a mesage to "self"?
     //  This is a hack.  When we have full-IP this should be removed.





More information about the cfe-commits mailing list