[cfe-commits] r69928 - in /cfe/trunk: lib/Sema/SemaDeclObjC.cpp test/SemaObjC/class-impl-1.m test/SemaObjC/synchronized.m

[Fariborz Jahanian]

Author: fjahanian
Date: Thu Apr 23 16:49:04 2009
New Revision: 69928

URL: http://llvm.org/viewvc/llvm-project?rev=69928&view=rev
Log:
Diagnose if an implementation implements a forward class
declaration (and avoid issuing bogus error later on).

Modified:
    cfe/trunk/lib/Sema/SemaDeclObjC.cpp
    cfe/trunk/test/SemaObjC/class-impl-1.m
    cfe/trunk/test/SemaObjC/synchronized.m

Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=69928&r1=69927&r2=69928&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Thu Apr 23 16:49:04 2009
@@ -623,8 +623,10 @@
   }  else {
     // Is there an interface declaration of this class; if not, warn!
     IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 
-    if (!IDecl)
+    if (!IDecl || IDecl->isForwardDecl()) {
       Diag(ClassLoc, diag::warn_undef_interface) << ClassName;
+      IDecl = 0;
+    }
   }
   
   // Check that super class name is valid class name

Modified: cfe/trunk/test/SemaObjC/class-impl-1.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/class-impl-1.m?rev=69928&r1=69927&r2=69928&view=diff

==============================================================================
--- cfe/trunk/test/SemaObjC/class-impl-1.m (original)
+++ cfe/trunk/test/SemaObjC/class-impl-1.m Thu Apr 23 16:49:04 2009
@@ -31,3 +31,10 @@
 
 @implementation INTF4 @end // expected-warning {{cannot find interface declaration for 'INTF4'}}
 
+ at class INTF5;
+
+ at implementation INTF5 {  // expected-warning {{cannot find interface declaration for 'INTF5'}}
+  int x;
+}
+ at end
+

Modified: cfe/trunk/test/SemaObjC/synchronized.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/synchronized.m?rev=69928&r1=69927&r2=69928&view=diff

==============================================================================
--- cfe/trunk/test/SemaObjC/synchronized.m (original)
+++ cfe/trunk/test/SemaObjC/synchronized.m Thu Apr 23 16:49:04 2009
@@ -1,6 +1,6 @@
 // RUN: clang-cc -fsyntax-only -verify %s
 
- at class PBXTrackableTaskManager;
+ at interface PBXTrackableTaskManager @end
 
 @implementation PBXTrackableTaskManager
 - (id) init {}