[cfe-commits] r69900 - in /cfe/trunk: lib/Analysis/GRExprEngine.cpp test/Analysis/misc-ps.m

[Ted Kremenek]

Author: kremenek
Date: Thu Apr 23 12:49:43 2009
New Revision: 69900

URL: http://llvm.org/viewvc/llvm-project?rev=69900&view=rev
Log:
Fix PR 4033: the analyzer shouldn't crash on computed gotos involving symbolic
target addresses.

Modified:
    cfe/trunk/lib/Analysis/GRExprEngine.cpp
    cfe/trunk/test/Analysis/misc-ps.m

Modified: cfe/trunk/lib/Analysis/GRExprEngine.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/GRExprEngine.cpp?rev=69900&r1=69899&r2=69900&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/GRExprEngine.cpp (original)
+++ cfe/trunk/lib/Analysis/GRExprEngine.cpp Thu Apr 23 12:49:43 2009
@@ -763,8 +763,7 @@
   }
   
   // This is really a catch-all.  We don't support symbolics yet.
-  
-  assert (V.isUnknown());
+  // FIXME: Implement dispatch for symbolic pointers.
   
   for (iterator I=builder.begin(), E=builder.end(); I != E; ++I)
     builder.generateNode(I, state);

Modified: cfe/trunk/test/Analysis/misc-ps.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/misc-ps.m?rev=69900&r1=69899&r2=69900&view=diff

==============================================================================
--- cfe/trunk/test/Analysis/misc-ps.m (original)
+++ cfe/trunk/test/Analysis/misc-ps.m Thu Apr 23 12:49:43 2009
@@ -249,7 +249,6 @@
 // regardless of how well the underlying StoreManager reasons about pointer
 // arithmetic.
 // <rdar://problem/6777209>
-
 void rdar_6777209(char *p) {
   if (p == 0)
     return;
@@ -260,3 +259,16 @@
   if (p == 0)
     *p = 'c'; // no-warning
 }
+
+// PR 4033.  A symbolic 'void *' pointer can be used as the address for a
+// computed goto.
+typedef void *Opcode;
+Opcode pr_4033_getOpcode();
+void pr_4033(void) {
+next_opcode:
+  {
+    Opcode op = pr_4033_getOpcode();
+    if (op) goto *op;
+  }
+}
+