[cfe-commits] r69894 - in /cfe/trunk: lib/Frontend/PCHReader.cpp lib/Sema/SemaDeclObjC.cpp test/PCH/objc_methods.h test/PCH/objc_methods.m

[Steve Naroff]

Author: snaroff
Date: Thu Apr 23 11:00:56 2009
New Revision: 69894

URL: http://llvm.org/viewvc/llvm-project?rev=69894&view=rev
Log:
More PushOnScopeChain() FIXME's.

Modified:
    cfe/trunk/lib/Frontend/PCHReader.cpp
    cfe/trunk/lib/Sema/SemaDeclObjC.cpp
    cfe/trunk/test/PCH/objc_methods.h
    cfe/trunk/test/PCH/objc_methods.m

Modified: cfe/trunk/lib/Frontend/PCHReader.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/PCHReader.cpp?rev=69894&r1=69893&r2=69894&view=diff

==============================================================================
--- cfe/trunk/lib/Frontend/PCHReader.cpp (original)
+++ cfe/trunk/lib/Frontend/PCHReader.cpp Thu Apr 23 11:00:56 2009
@@ -2743,7 +2743,6 @@
   case DeclarationName::ObjCOneArgSelector:
   case DeclarationName::ObjCMultiArgSelector:
     return DeclarationName(GetSelector(Record, Idx));
-    break;
 
   case DeclarationName::CXXConstructorName:
     return Context.DeclarationNames.getCXXConstructorName(

Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=69894&r1=69893&r2=69894&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Thu Apr 23 11:00:56 2009
@@ -206,8 +206,7 @@
   
   ObjCAliasDecls[AliasName] = AliasDecl;
 
-  // FIXME: PushOnScopeChains?
-  CurContext->addDecl(Context, AliasDecl);
+  PushOnScopeChains(AliasDecl, TUScope);
   if (!CheckObjCDeclScope(AliasDecl))
     TUScope->AddDecl(DeclPtrTy::make(AliasDecl));
 
@@ -1048,8 +1047,7 @@
                                         IdentList[i], SourceLocation(), true);
       ObjCInterfaceDecls[IdentList[i]] = IDecl;
 
-      // FIXME: PushOnScopeChains?
-      CurContext->addDecl(Context, IDecl);
+      PushOnScopeChains(IDecl, TUScope);
       // Remember that this needs to be removed when the scope is popped.
       TUScope->AddDecl(DeclPtrTy::make(IDecl));
     }

Modified: cfe/trunk/test/PCH/objc_methods.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/PCH/objc_methods.h?rev=69894&r1=69893&r2=69894&view=diff

==============================================================================
--- cfe/trunk/test/PCH/objc_methods.h (original)
+++ cfe/trunk/test/PCH/objc_methods.h Thu Apr 23 11:00:56 2009
@@ -4,3 +4,8 @@
 + alloc;
 - (void)instMethod;
 @end
+
+ at class TestForwardClassDecl;
+
+// FIXME: @compatibility_alias  AliasForTestPCH TestPCH;
+

Modified: cfe/trunk/test/PCH/objc_methods.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/PCH/objc_methods.m?rev=69894&r1=69893&r2=69894&view=diff

==============================================================================
--- cfe/trunk/test/PCH/objc_methods.m (original)
+++ cfe/trunk/test/PCH/objc_methods.m Thu Apr 23 11:00:56 2009
@@ -7,6 +7,10 @@
 
 void func() {
  TestPCH *xx;
+ TestForwardClassDecl *yy;
+// FIXME:
+// AliasForTestPCH *zz;
+ 
 #if 0
  xx = [TestPCH alloc];
  [xx instMethod];