[cfe-commits] r68494 - in /cfe/trunk/lib: Basic/Targets.cpp Lex/Preprocessor.cpp

[Chris Lattner]

On Apr 7, 2009, at 12:33 PM, Eli Friedman wrote:

> On Mon, Apr 6, 2009 at 9:48 PM, Chris Lattner <sabre at nondot.org>  
> wrote:
>> The __weak and __strong defines are common to all darwin targets
>> and are even set in C mode.  As such, move them to Targets.cpp.
>
> Is it intentional that we're not setting these on non-Darwin targets
> in ObjC mode?  This is causing a bunch of test failures on Linux.

Hi Eli,

I don't have a strong preference, I was just following GCC behavior  
here and trying to avoid polluting the C namespace.  I suppose that it  
is fine it just set these unconditionally on all targets.  Do you agree?

>
> Should this be controlled by -fnext-runtime rather than the target  
> triple?

That won't work because these are needed in C mode also, which doesn't  
get that flag consistently.

-Chris