[cfe-commits] r68844 - in /cfe/trunk: lib/AST/ASTContext.cpp test/CodeGenObjC/objc2-no-strong-cast.m

[Fariborz Jahanian]

Author: fjahanian
Date: Fri Apr 10 19:00:54 2009
New Revision: 68844

URL: http://llvm.org/viewvc/llvm-project?rev=68844&view=rev
Log:
Non-pointer objects are none gc'able regardles of
the attribute set on them.

Added:
    cfe/trunk/test/CodeGenObjC/objc2-no-strong-cast.m
Modified:
    cfe/trunk/lib/AST/ASTContext.cpp

Modified: cfe/trunk/lib/AST/ASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=68844&r1=68843&r2=68844&view=diff

==============================================================================
--- cfe/trunk/lib/AST/ASTContext.cpp (original)
+++ cfe/trunk/lib/AST/ASTContext.cpp Fri Apr 10 19:00:54 2009
@@ -2694,6 +2694,10 @@
       else if (Ty->isPointerType())
         return getObjCGCAttrKind(Ty->getAsPointerType()->getPointeeType());
     }
+    // Non-pointers have none gc'able attribute regardless of the attribute
+    // set on them.
+    else if (!isObjCObjectPointerType(Ty) && !Ty->isPointerType())
+      return QualType::GCNone;
   }
   return GCAttrs;
 }

Added: cfe/trunk/test/CodeGenObjC/objc2-no-strong-cast.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/objc2-no-strong-cast.m?rev=68844&view=auto

==============================================================================
--- cfe/trunk/test/CodeGenObjC/objc2-no-strong-cast.m (added)
+++ cfe/trunk/test/CodeGenObjC/objc2-no-strong-cast.m Fri Apr 10 19:00:54 2009
@@ -0,0 +1,22 @@
+// RUN: clang-cc -emit-llvm -o %t %s
+
+ at interface PDFViewPrivateVars 
+{
+ at public
+	__attribute__((objc_gc(strong))) char *addedTooltips;
+}
+ at end
+
+ at interface PDFView 
+{
+    PDFViewPrivateVars *_pdfPriv;
+}
+ at end
+
+ at implementation PDFView
+- (void) addTooltipsForPage
+{
+ _pdfPriv->addedTooltips[4] = 1;
+}
+ at end
+