[cfe-commits] r68551 - in /cfe/trunk: lib/Sema/SemaDeclObjC.cpp test/SemaObjC/no-gc-weak-test.m

[Fariborz Jahanian]

Author: fjahanian
Date: Tue Apr  7 16:25:06 2009
New Revision: 68551

URL: http://llvm.org/viewvc/llvm-project?rev=68551&view=rev
Log:
Now that we have __weak defined as attribute in all modes,
we must not issue gc-specific errors in non-gc mode.


Added:
    cfe/trunk/test/SemaObjC/no-gc-weak-test.m
Modified:
    cfe/trunk/lib/Sema/SemaDeclObjC.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=68551&r1=68550&r2=68551&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Tue Apr  7 16:25:06 2009
@@ -1825,7 +1825,8 @@
         return DeclPtrTy();
       }
       // __weak is explicit. So it works on Canonical type.
-      if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak()) {
+      if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() &&
+          getLangOptions().getGCMode() != LangOptions::NonGC) {
         Diag(PropertyLoc, diag::error_weak_property)
         << property->getDeclName() << Ivar->getDeclName();
         return DeclPtrTy();

Added: cfe/trunk/test/SemaObjC/no-gc-weak-test.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/no-gc-weak-test.m?rev=68551&view=auto

==============================================================================
--- cfe/trunk/test/SemaObjC/no-gc-weak-test.m (added)
+++ cfe/trunk/test/SemaObjC/no-gc-weak-test.m Tue Apr  7 16:25:06 2009
@@ -0,0 +1,14 @@
+// RUN: clang-cc  -fsyntax-only -verify %s
+
+ at interface Subtask
+{
+  id _delegate;
+}
+ at property(nonatomic,readwrite,assign)   id __weak       delegate;
+ at end
+
+ at implementation Subtask
+ at synthesize delegate = _delegate;
+ at end
+
+